Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CRD to use lower camel case #87

Merged
merged 7 commits into from
Nov 7, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add warning for strategy all-in-one
Signed-off-by: Gary Brown <[email protected]>
  • Loading branch information
objectiser committed Nov 7, 2018
commit 118130ec5042db9b0265408e9ed1f80cdaefb2da
5 changes: 5 additions & 0 deletions pkg/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ type Controller interface {
func NewController(ctx context.Context, jaeger *v1alpha1.Jaeger) Controller {
normalize(jaeger)

if jaeger.Spec.Strategy == "all-in-one" {
logrus.Warnf("Strategy 'all-in-one' is no longer supported, please use 'allInOne'")
jaeger.Spec.Strategy = "allInOne"
}

logrus.Debugf("Jaeger strategy: %s", jaeger.Spec.Strategy)
if jaeger.Spec.Strategy == "allInOne" {
return newAllInOneController(ctx, jaeger)
Expand Down