-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'openapi' generated resources #819
Added 'openapi' generated resources #819
Conversation
Looks like the OpenShift tests need to run on a newer OpenShift version. Here's the output of the tests against a production-quality OpenShift 4.2 cluster:
OpenShift version:
cc @kevinearls |
I'm marking this as WIP, because we don't want this merged before 1.16. |
4cc6007
to
0f91d7c
Compare
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
0f91d7c
to
416f476
Compare
Removed WIP, this is ready to be reviewed. |
@@ -49,12 +48,12 @@ format: | |||
.PHONY: lint | |||
lint: | |||
@echo Linting... | |||
@${GOPATH}/bin/golint -set_exit_status=1 $(PACKAGES) | |||
@./.ci/lint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the gopath set in the script? I remember that for format it wasn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If golint
is in the PATH, then it's used. If none is in the path, then GOPATH is used, if set. If golint still can't be found, the script will fail.
GOLINT=golint
command -v ${GOLINT} > /dev/null
if [ $? != 0 ]; then
if [ -z ${GOPATH} ]; then
GOLINT="${GOPATH}/bin/golint"
fi
fi
I tried to deploy the CRD using this yaml, but seems the metadata is too long. Could you please take a look? @jpkrohling
|
I ran into the same problem when developing and was told that CRDs have to be created/deleted, not applied. When using |
Thanks! |
I hit the same issue when I input |
Resolves #763
Signed-off-by: Juraci Paixão Kröhling [email protected]