Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table of contents on readme #73

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Oct 18, 2018

As we have the badges, the table of contents macro wasn't getting called. One way of fixing this is like this PR. Another way is to get the header + toc as the first things in the doc, with the badges next.

Before:
image

After:
image

Signed-off-by: Juraci Paixão Kröhling [email protected]

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    99.3%   99.3%           
======================================
  Files          17      17           
  Lines         718     718           
======================================
  Hits          713     713           
  Misses          5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b675627...39e66df. Read the comment docs.

@jpkrohling jpkrohling merged commit f520023 into jaegertracing:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants