Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add labels to cronjob pod template #707

Merged
merged 3 commits into from
Oct 21, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Oct 17, 2019

Signed-off-by: yeya24 [email protected]

fixes #697

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing missing is a test, to make sure the expected labels can be found on both expected places.

@yeya24
Copy link
Contributor Author

yeya24 commented Oct 18, 2019

Looks good! The only thing missing is a test, to make sure the expected labels can be found on both expected places.

Sure, I will add it ASAP

Signed-off-by: yeya24 <[email protected]>
@yeya24
Copy link
Contributor Author

yeya24 commented Oct 18, 2019

Looks good! The only thing missing is a test, to make sure the expected labels can be found on both expected places.

@jpkrohling Could you please check if this is OK? Thank you very much.

@yeya24
Copy link
Contributor Author

yeya24 commented Oct 18, 2019

Seems the install-docker script has some problems...

@jpkrohling
Copy link
Contributor

image

I started the failed checks again. Once it passes, I'll merge it.

@jpkrohling jpkrohling merged commit f1ff089 into jaegertracing:master Oct 21, 2019
@jpkrohling
Copy link
Contributor

@yeya24 thanks for your PR!

@yeya24 yeya24 deleted the add-missing-label branch October 21, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No identifying labels on ES Index Cleaner pod
2 participants