Bring jaeger operator repo inline with contributing guidelines in mai… #664
Conversation
…n Jaeger repo Signed-off-by: Gary Brown <[email protected]>
| simplest solution is to squash the commits into one and sign it. For example, | ||
| suppose that your branch history looks like this: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
This file is currently a straight copy of the jaeger repo version, which makes updating eaiser - but means the list of commits here given as example are related to that repo. Not sure it matters as just used for illustration.
There was a problem hiding this comment.
I don't think it matters.
| @@ -0,0 +1,157 @@ | |||
| # How to Contribute to Jaeger | |||
There was a problem hiding this comment.
Originally I appended "Operator" to this title and in a few other places. But decided to revert as the instructions basically relate to all jaeger repos. They are just here for convenience.
CONTRIBUTING_GUIDELINES.md
Outdated
| make sure the year is current and the copyright says "The Jaeger Authors". | ||
|
|
||
| ``` | ||
| // Copyright (c) 2018 The Jaeger Authors. |
There was a problem hiding this comment.
Probably not something to fix here, but at the source. The year probably needs to be updated ;)
| simplest solution is to squash the commits into one and sign it. For example, | ||
| suppose that your branch history looks like this: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
I don't think it matters.
Signed-off-by: Gary Brown <[email protected]>
…n Jaeger repo
As mentioned in #663 (comment), the DCO instructions aren't clear - so have copied the
CONTRIBUTING_GUIDELINES.mdfrom jaeger repo, and removed the DCO section from the currentCONTRIBUTING.md, to make the jaeger-operator repo more consistent with the jaeger repo. Also added the missing referencedDCOfile.Signed-off-by: Gary Brown [email protected]