Load env variables in the given secretName in Spark dependencies #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
LGTM. Perhaps @objectiser would like to take a look as well.
objectiser
approved these changes
Sep 9, 2019
| @@ -79,6 +79,17 @@ func TestCreate(t *testing.T) { | |||
| assert.NotNil(t, CreateSparkDependencies(&v1.Jaeger{Spec: v1.JaegerSpec{Storage: v1.JaegerStorageSpec{Type: "elasticsearch"}}})) | |||
| } | |||
|
|
|||
| func TestSparkDependenciesSecretSecrets(t *testing.T) { | |||
There was a problem hiding this comment.
nit: TestSparkDependenciesSecrets ? - if changed can you also update the test name in the line below.
There was a problem hiding this comment.
Good suggestion. It is changed now.
|
Before merging, please rebase this PR. Perhaps we'll get a clean CI run then. A couple of axis in the first run failed due to some networking issue, and the second is failing due to actions/checkout#23. |
Signed-off-by: Gorka Maiztegi <[email protected]>
Signed-off-by: Gorka Maiztegi <[email protected]>
Signed-off-by: Gorka Maiztegi <[email protected]>
|
Everything seems fine now. Thank you for your comments guys. |
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I store the Elasticsearch credentials in a secret which I then pass in the
storage.secretNameparameter. These credentials are then correctly loaded by the collector, the query and the Elasticsearch cleaner cronjob, but not by Spark dependencies.I am noob Go programmer so feel free to edit this piece of code as you see fit.