Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badger to supported list of storage types #616

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Add badger to supported list of storage types #616

merged 4 commits into from
Aug 27, 2019

Conversation

objectiser
Copy link
Contributor

Fixes #564

Signed-off-by: Gary Brown [email protected]

@jpkrohling
Copy link
Contributor

Travis failed with a message about gocontext. I restarted the job, but then realized that it wasn't the typical failure, and indeed there's a change about go context in this PR. I can't copy the error message, as I restarted the job before I could copy the error message, but perhaps you might want to revert that change?

@codecov
Copy link

codecov bot commented Aug 23, 2019 •
edited
Loading

Codecov Report

Merging #616 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   91.18%   91.18%   +<.01%     
==========================================
  Files          73       73              
  Lines        3651     3654       +3     
==========================================
+ Hits         3329     3332       +3     
  Misses        228      228              
  Partials       94       94
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/storage/types.go 100% <100%> (ø) ⬆️
pkg/strategy/controller.go 97.79% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7664ef3...a74e92e. Read the comment docs.

@objectiser
Copy link
Contributor Author

@jpkrohling I ran the tests locally, so not sure when it reformatted to change that import - but hopefully fixed now.

@objectiser objectiser requested a review from jpkrohling August 23, 2019 16:16
jpkrohling
jpkrohling approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on the naming of the examples, but can be merged as-is.

deploy/examples/simplest-with-badger-and-volume.yaml Outdated
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
name: simplest-with-badger-and-volume
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about with-badger-persistent?

deploy/examples/simplest-with-badger.yaml Outdated
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
name: simplest-with-badger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just with-badger?

@codecov-io
Copy link

Codecov Report

Merging #616 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   91.18%   91.18%   +<.01%     
==========================================
  Files          73       73              
  Lines        3651     3654       +3     
==========================================
+ Hits         3329     3332       +3     
  Misses        228      228              
  Partials       94       94
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/storage/types.go 100% <100%> (ø) ⬆️
pkg/strategy/controller.go 97.79% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7664ef3...7b60944. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Aug 27, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #616 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   91.18%   91.18%   +<.01%     
==========================================
  Files          73       73              
  Lines        3651     3654       +3     
==========================================
+ Hits         3329     3332       +3     
  Misses        228      228              
  Partials       94       94
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/storage/types.go 100% <100%> (ø) ⬆️
pkg/strategy/controller.go 97.79% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1985254...5bf7216. Read the comment docs.

@jpkrohling jpkrohling merged commit dcd7873 into jaegertracing:master Aug 27, 2019
@objectiser objectiser deleted the badger branch August 27, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to add badger as backend storage
3 participants
@objectiser @jpkrohling @codecov-io