Agent service ports with correct protocol #579
Conversation
Signed-off-by: Dawid Nowak <[email protected]>
|
@objectiser I think the general recommendation is to use the downward API to get the node's IP and configure the client to go directly to the node, so, this service here shouldn't be used much (at all?). Do you remember if and where this service is used? In any case, the PR looks correct in that it's setting the ports to their expected protocols. |
|
@dnovvak: the same question applies to you: what makes you use the service instead of the downward API to get the local node's IP? |
|
@jpkrohling no where as far as I know. |
|
@dnovvak could you please run |
Signed-off-by: Dawid Nowak <[email protected]>
|
@jpkrohling Yes, just fixed formatting. It was not so easy on windows :) thanks for patience
My use case is rather unusual and shouldn't be considered as important I think. I needed to expose agent outside k8s cluster (only for dev/test purpose, for a while). I tried to do this through nginx ingress (details here) but without success. After quick investigation I found that service for jaeger-agent did not expose UDP ports but all TCP. That's the story. |
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 91.26% 91.27% +<.01%
==========================================
Files 73 73
Lines 3652 3655 +3
==========================================
+ Hits 3333 3336 +3
Misses 227 227
Partials 92 92
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 91.26% 91.27% +<.01%
==========================================
Files 73 73
Lines 3652 3655 +3
==========================================
+ Hits 3333 3336 +3
Misses 227 227
Partials 92 92
Continue to review full report at Codecov.
|
Fixes: #577