Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linkerd.io/inject=disabled annotation #507

Merged
merged 1 commit into from
Jul 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/cronjob/es_index_cleaner.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ func CreateEsIndexCleaner(jaeger *v1.Jaeger) *batchv1beta1.CronJob {
Annotations: map[string]string{
"prometheus.io/scrape": "false",
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
},
},
Expand Down
2 changes: 2 additions & 0 deletions pkg/cronjob/es_rollover.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func rollover(jaeger *v1.Jaeger) batchv1beta1.CronJob {
Annotations: map[string]string{
"prometheus.io/scrape": "false",
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
},
Spec: corev1.PodSpec{
Expand Down Expand Up @@ -107,6 +108,7 @@ func lookback(jaeger *v1.Jaeger) batchv1beta1.CronJob {
Annotations: map[string]string{
"prometheus.io/scrape": "false",
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
},
Spec: corev1.PodSpec{
Expand Down
1 change: 1 addition & 0 deletions pkg/cronjob/spark_dependencies.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ func CreateSparkDependencies(jaeger *v1.Jaeger) *batchv1beta1.CronJob {
Annotations: map[string]string{
"prometheus.io/scrape": "false",
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
},
},
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func (a *Agent) Get() *appsv1.DaemonSet {
"prometheus.io/scrape": "true",
"prometheus.io/port": strconv.Itoa(int(adminPort)),
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
Labels: labels,
}
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/agent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ func TestDaemonSetAgentAnnotations(t *testing.T) {
assert.Equal(t, "false", dep.Spec.Template.Annotations["sidecar.istio.io/inject"])
assert.Equal(t, "world", dep.Spec.Template.Annotations["hello"])
assert.Equal(t, "false", dep.Spec.Template.Annotations["prometheus.io/scrape"])
assert.Equal(t, "disabled", dep.Spec.Template.Annotations["linkerd.io/inject"])
}

func TestDaemonSetAgentLabels(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/all-in-one.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func (a *AllInOne) Get() *appsv1.Deployment {
"prometheus.io/scrape": "true",
"prometheus.io/port": strconv.Itoa(int(adminPort)),
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
Labels: labels,
}
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/all-in-one_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ func TestAllInOneAnnotations(t *testing.T) {
assert.Equal(t, "false", dep.Spec.Template.Annotations["sidecar.istio.io/inject"])
assert.Equal(t, "world", dep.Spec.Template.Annotations["hello"])
assert.Equal(t, "false", dep.Spec.Template.Annotations["prometheus.io/scrape"])
assert.Equal(t, "disabled", dep.Spec.Template.Annotations["linkerd.io/inject"])
}

func TestAllInOneLabels(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func (c *Collector) Get() *appsv1.Deployment {
"prometheus.io/scrape": "true",
"prometheus.io/port": strconv.Itoa(int(adminPort)),
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
Labels: labels,
}
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/collector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ func TestCollectorAnnotations(t *testing.T) {
assert.Equal(t, "false", dep.Spec.Template.Annotations["sidecar.istio.io/inject"])
assert.Equal(t, "world", dep.Spec.Template.Annotations["hello"])
assert.Equal(t, "false", dep.Spec.Template.Annotations["prometheus.io/scrape"])
assert.Equal(t, "disabled", dep.Spec.Template.Annotations["linkerd.io/inject"])
}

func TestCollectorLabels(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/ingester.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ func (i *Ingester) Get() *appsv1.Deployment {
"prometheus.io/scrape": "true",
"prometheus.io/port": strconv.Itoa(int(adminPort)),
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
Labels: labels,
}
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/ingester_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ func TestIngesterAnnotations(t *testing.T) {
assert.Equal(t, "false", dep.Spec.Template.Annotations["sidecar.istio.io/inject"])
assert.Equal(t, "world", dep.Spec.Template.Annotations["hello"])
assert.Equal(t, "false", dep.Spec.Template.Annotations["prometheus.io/scrape"])
assert.Equal(t, "disabled", dep.Spec.Template.Annotations["linkerd.io/inject"])
}

func TestIngesterLabels(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ func (q *Query) Get() *appsv1.Deployment {
"prometheus.io/scrape": "true",
"prometheus.io/port": strconv.Itoa(int(adminPort)),
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",

// note that we are explicitly using a string here, not the value from `inject.Annotation`
// this has two reasons:
Expand Down
1 change: 1 addition & 0 deletions pkg/deployment/query_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ func TestQueryAnnotations(t *testing.T) {
assert.Equal(t, "false", dep.Spec.Template.Annotations["sidecar.istio.io/inject"])
assert.Equal(t, "world", dep.Spec.Template.Annotations["hello"])
assert.Equal(t, "false", dep.Spec.Template.Annotations["prometheus.io/scrape"])
assert.Equal(t, "disabled", dep.Spec.Template.Annotations["linkerd.io/inject"])
}

func TestQueryLabels(t *testing.T) {
Expand Down
1 change: 1 addition & 0 deletions pkg/storage/cassandra_dependencies.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func cassandraDeps(jaeger *v1.Jaeger) []batchv1.Job {
annotations := map[string]string{
"prometheus.io/scrape": "false",
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
}

// TODO: should this be configurable? Would we ever think that 2 minutes is OK for this job to complete?
Expand Down
1 change: 1 addition & 0 deletions pkg/storage/elasticsearch_dependencies.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func elasticsearchDependencies(jaeger *v1.Jaeger) []batchv1.Job {
Annotations: map[string]string{
"prometheus.io/scrape": "false",
"sidecar.istio.io/inject": "false",
"linkerd.io/inject": "disabled",
},
},
Spec: corev1.PodSpec{
Expand Down