Add install SDK goal to make

[pavolloffay]

Signed-off-by: Pavol Loffay [email protected]

[codecov]

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          64       64           
  Lines        3142     3142           
=======================================
  Hits         2878     2878           
  Misses        184      184           
  Partials       80       80

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f67fd4...f6fa24e. Read the comment docs.

[codecov]

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          64       64           
  Lines        3142     3142           
=======================================
  Hits         2878     2878           
  Misses        184      184           
  Partials       80       80

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f67fd4...b00efda. Read the comment docs.

[jpkrohling]

Could you please paste the output for the new targets?

[pavolloffay]

It should be available in travis output.

[jpkrohling]

It should be available in travis output.

Travis sets the -x flag, which prints out more than what it would print locally.

[pavolloffay]

The output in travis is the same as locally. What are your concerns with output? Could you be more specific please?

locally:

make install-sdk install-tools                                                                                                                    4:39 
curl https://github.com/operator-framework/operator-sdk/releases/download/v0.8.1/operator-sdk-v0.8.1-x86_64-linux-gnu -sLo /home/ploffay/projects/golang/bin/operator-sdk
chmod +x /home/ploffay/projects/golang/bin/operator-sdk
go get -u golang.org/x/lint/golint
go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'
go get github.com/securego/gosec/cmd/gosec/...
go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'

travis: https://travis-ci.org/jaegertracing/jaeger-operator/jobs/541164268#L230

$ make install-sdk install-tools
curl https://github.com/operator-framework/operator-sdk/releases/download/v0.8.1/operator-sdk-v0.8.1-x86_64-linux-gnu -sLo /home/travis/gopath/bin/operator-sdk
chmod +x /home/travis/gopath/bin/operator-sdk
go get -u golang.org/x/lint/golint
go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'
go get github.com/securego/gosec/cmd/gosec/...
go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'

[jpkrohling]

Interesting, I thought Travis was more verbose. My concern is that all our targets are silent, and these new targets are verbose. Instead of showing the commands (curl, chmod, go get...), omit them and their outputs, unless a failure happens.

[pavolloffay]

I don't really care this is one-time command folks run when start with the project.

Do you want to add @ before the commands?

[jpkrohling]

LGTM, just need to print out something like "Installing SDK..." at the beginning of the task, like the other tasks in the Makefile. Like:

@echo Installing SDK...