Log the operator image name when created #452
Conversation
Signed-off-by: Kevin Earls <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=========================================
+ Coverage 91.57% 91.6% +0.03%
=========================================
Files 64 64
Lines 3132 3144 +12
=========================================
+ Hits 2868 2880 +12
Misses 184 184
Partials 80 80
Continue to review full report at Codecov.
|
|
@jpkrohling @objectiser @pavolloffay Please review |
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls <[email protected]>
test/e2e/utils.go
Outdated
| for _, container := range containers { | ||
| if container.Name == "jaeger-operator" { | ||
| for _, env := range container.Env { | ||
| if env.Name == "WATCH_NAMESPACE" { |
There was a problem hiding this comment.
This is still going to return the set of images for all operators that are deployed, rather than the single image associated with the operator that is displaying the message.
Think it would be better to get the POD_NAME environment variable value for the operator instance, and then look up the image associated with the jaeger-operator container in that pod?
Signed-off-by: Kevin Earls <[email protected]>
test/e2e/utils.go
Outdated
|
|
||
| deployment, err := kubeclient.AppsV1().Deployments(namespace).Get("jaeger-operator", metav1.GetOptions{IncludeUninitialized: false}) | ||
| if err != nil { | ||
| if !strings.Contains(err.Error(), "not found") { |
There was a problem hiding this comment.
Wondering why the error is just not returned?
Signed-off-by: Kevin Earls <[email protected]>
Signed-off-by: Kevin Earls [email protected]
This is useful for when we want to validate that we're really testing against the image that we think we're using.