Update Operator SDK to 0.8.1 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are passing. I got some failures with the streaming tests at first, but manually removing the Kafka |
jpkrohling
force-pushed
the
448-Update-SDK-version
branch
5 times, most recently
from
0a920c6 to
359e0a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
======================================
Coverage 91.6% 91.6%
======================================
Files 64 64
Lines 3144 3144
======================================
Hits 2880 2880
Misses 184 184
Partials 80 80Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 64 64
Lines 3142 3142
=======================================
Hits 2878 2878
Misses 184 184
Partials 80 80Continue to review full report at Codecov.
|
objectiser
reviewed
Jun 3, 2019
| @@ -2,6 +2,8 @@ | |||
| build/_output | |||
| build/_test | |||
| deploy/test | |||
| vendor | |||
There was a problem hiding this comment.
Why no longer persist the vendor folder?
There was a problem hiding this comment.
Following discussion, agree better to align with recommended approach for modules.
There was a problem hiding this comment.
My understanding is that Go Modules supports vendor for backwards compatibility but is quite opinionated in this area. Modules do not reside under vendor: rather, a go.mod and go.sum record the dependencies and their checksums, so that reproducible builds should be possible even without a vendor directory.
objectiser
approved these changes
Jun 3, 2019
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
448-Update-SDK-version
branch
from
95bf31d to
2f67fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is divided in two commits: the first is to move from
deptogo modules, as that's the new default for the Operator SDK. Note that it requires Go 1.11 withGO111MODULE=onor Go 1.12, where modules is activated by default. For my local development environment, I opted for using Go 1.12.The second commit is to implement changes that I see when a new operator is generator, including the new
tools.goat the root of the project and a newDockerfilewith a couple of scripts.