Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that context is not nil before calling cleanup #413

Merged
merged 1 commit into from
May 15, 2019
Merged

Check that context is not nil before calling cleanup #413

merged 1 commit into from
May 15, 2019

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls [email protected]

If prepare fails verify that the context is not nil before calling cleanup.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files          64       64           
  Lines        3094     3094           
=======================================
  Hits         2776     2776           
  Misses        216      216           
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7fdd67...a834b1c. Read the comment docs.

@objectiser objectiser merged commit c4c6a07 into jaegertracing:master May 15, 2019
@kevinearls kevinearls deleted the avoid-nil-memory-reference branch May 15, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants