Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resources requests/limits to oauth_proxy #410

Merged
merged 2 commits into from
May 15, 2019
Merged

Add resources requests/limits to oauth_proxy #410

merged 2 commits into from
May 15, 2019

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented May 13, 2019 •
edited
Loading

Fixes Issue #399

@codecov
Copy link

codecov bot commented May 13, 2019 •
edited
Loading

Codecov Report

Merging #410 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   89.72%   89.72%   +<.01%     
==========================================
  Files          64       64              
  Lines        3094     3096       +2     
==========================================
+ Hits         2776     2778       +2     
  Misses        216      216              
  Partials      102      102
Impacted Files Coverage Δ
pkg/inject/oauth-proxy.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7fdd67...dcc6096. Read the comment docs.

@rubenvp8510 rubenvp8510 changed the title Add resources requests/limits to oauth_proxy [WIP] Add resources requests/limits to oauth_proxy May 13, 2019
@rubenvp8510 rubenvp8510 changed the title [WIP] Add resources requests/limits to oauth_proxy Add resources requests/limits to oauth_proxy May 14, 2019
@rubenvp8510
Copy link
Collaborator Author

@pavolloffay Could you please review? Thanks

objectiser
objectiser reviewed May 15, 2019
View reviewed changes
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add a test though, similar to other places where resources have been added.

@rubenvp8510
Copy link
Collaborator Author

@objectiser Done!

@objectiser objectiser merged commit d5ff5a6 into jaegertracing:master May 15, 2019
@objectiser objectiser mentioned this pull request May 16, 2019
Closed
@pavolloffay pavolloffay added the enhancement New feature or request label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@objectiser objectiser objectiser approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubenvp8510 @objectiser @pavolloffay