Change how Kafka is configured for collector and ingester #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <[email protected]>
jpkrohling
approved these changes
May 3, 2019
| collector: | ||
| options: | ||
| kafka: # <1> | ||
| producer: |
There was a problem hiding this comment.
This is the strongest argument in favor of strong typing for CLI options, IMO
README.adoc
Outdated
| @@ -262,6 +269,8 @@ spec: | |||
| <1> Identifies the kafka configuration used by the collector, to produce the messages, and the ingester to consume the messages | |||
| <2> The deadlock interval can be disabled to avoid the ingester being terminated when no messages arrive within the default 1 minute period | |||
|
|
|||
| NOTE: A Kafka environment can be configured using link:https://strimzi.io/[Strimzi's Kafka operator]. | |||
There was a problem hiding this comment.
TIP instead of NOTE?
https://asciidoctor.org/docs/user-manual/#admonition
Signed-off-by: Gary Brown <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 89.72% 89.71% -0.01%
==========================================
Files 64 64
Lines 3094 3092 -2
==========================================
- Hits 2776 2774 -2
Misses 216 216
Partials 102 102
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kafka options were changed in Jaeger 1.11, to use specific properties for consumer and producer sides. The existing shared properties have been deprecated.
With the shared properties, it was possible for have a simplified streaming CR that only defined the kafka properties in storage and/or ingester components - however now the properties are specific to the producer/consumer, they have to be explicitly listed in the relevant component's options.
Unfortunately there is no way to make this backward compatible, as otherwise unexpected properties are passed to the collector. So this will need to be a breaking change - although only affects the streaming stragegy and kafka options.
Tested using strimzi. Next step will be to provide some e2e tests for streaming.
Signed-off-by: Gary Brown [email protected]