Make sure to call ctx.cleanup if prepare() fails #389
Conversation
Signed-off-by: Kevin Earls <[email protected]>
| @@ -15,7 +16,11 @@ import ( | |||
|
|
|||
| // Cassandra runs a test with Cassandra as the backing storage | |||
| func Cassandra(t *testing.T) { | |||
| ctx := prepare(t) | |||
| ctx, err := prepare(t) | |||
There was a problem hiding this comment.
Could we call prepare in the caller so each test would not have to repeat this block?
There was a problem hiding this comment.
@pavolloffay Once I finish the other changes I am making for reporting it will be called in the Setup method, only once per suite. https://github.com/jaegertracing/jaeger-operator/blob/master/test/e2e/all_in_one_test.go#L36-L44
I've run into this bug a few times though, so I wanted to get this done first.
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 64 64
Lines 3094 3094
=======================================
Hits 2776 2776
Misses 216 216
Partials 102 102Continue to review full report at Codecov.
|
kevinearls
changed the title
|
@pavolloffay @objectiser @jpkrohling Please review. |
Signed-off-by: Kevin Earls [email protected]
This fixed #388 Currently if tests fail during the prepare() call ctx.cleanup() will not be called and the namespace created for the test does not get cleaned up.