Fix rbac policy issue with blockOwnerDeletion #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 64 64
Lines 3094 3094
=======================================
Hits 2776 2776
Misses 216 216
Partials 102 102Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
LGTM, but would be nice to get a confirmation from @kevinearls that it fixes the issue he reported.
|
@objectiser @jpkrohling will try it now |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
Tested on minishift and minikube - to make sure operator deploys ok, but also that the service jaeger-operator is still removed when operator uninstalled.
Signed-off-by: Gary Brown [email protected]