-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise menu to include Log Out option when using OAuth Proxy #344
Conversation
Signed-off-by: Gary Brown <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 89.81% 89.88% +0.07%
==========================================
Files 64 64
Lines 3014 3035 +21
==========================================
+ Hits 2707 2728 +21
Misses 207 207
Partials 100 100
Continue to review full report at Codecov.
|
] | ||
}, | ||
{ | ||
"label": "Log Out", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would render the "Log out" right next to the "About" item, right? Are they aligned to the main options, or are they aligned to the right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both "About" and "Log Out" are rendered together on the right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Looks good to me, then
@jpkrohling Seems like there may be a way to logout into the same tab - I'll take a look in case we can get this one into the release. |
… fix coverage Signed-off-by: Gary Brown <[email protected]>
@jpkrohling Fixed based on Yuri's suggestion - could you give it a try in minishift with |
Adds menu (About sub-menu and Log Out) when OAuth Proxy configured.
Currently when selecting the Log Out button it opens another tab - this may require a change in jaeger-ui.
Signed-off-by: Gary Brown [email protected]