Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command to deploy the simplest operator #34

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Fix command to deploy the simplest operator #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ At this point, a Jaeger instance can be installed:

[source,bash]
----
kubectl apply -f deploy/simplest.yaml
kubectl apply -f deploy/examples/simplest.yaml
kubectl get jaegers
kubectl get pods
----

To remove the instance:
[source,bash]
----
kubectl delete -f deploy/simplest.yaml
kubectl delete -f deploy/examples/simplest.yaml
----

Tests should be simple unit tests and/or end-to-end tests. For small changes, unit tests should be sufficient, but every new feature should be accompanied with end-to-end tests as well. Tests can be executed with:
Expand Down