Disable spark dependencies for self provisioned es

[pavolloffay]

Resolves #316

We don't want auto-enabled spark deps for self-provisioned ES

Signed-off-by: Pavol Loffay [email protected]

[jpkrohling]

This change is 

[codecov]

Codecov Report

Merging #319 into master will increase coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   88.65%   88.94%   +0.29%     
==========================================
  Files          70       69       -1     
  Lines        3173     3112      -61     
==========================================
- Hits         2813     2768      -45     
+ Misses        246      234      -12     
+ Partials      114      110       -4

Impacted Files	Coverage Δ
pkg/strategy/controller.go	96.96% <100%> (+0.06%)	⬆️
pkg/apis/jaegertracing/v1/jaeger_types.go	100% <0%> (ø)	⬆️
pkg/controller/jaeger/status/collector.go
pkg/controller/jaeger/jaeger_controller.go	36.17% <0%> (+2.83%)	⬆️
pkg/controller/jaeger/deployment.go	62.96% <0%> (+4.62%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a898f...0f37ea7. Read the comment docs.

[objectiser]

@pavolloffay Do we need to document this somewhere, or produce a warning message?

[pavolloffay]

The log message in the controller would be logged on every loop. I will just add it to the readme

INFO[0055] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0088] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0103] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0108] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0113] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0118] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0123] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0128] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0134] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0139] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0144] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0149] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging
INFO[0154] Auto enabling for Spark dependencies is disabled. Spark dependencies are not support for self provisioned Elasticsearch  instance=simple-prod namespace=openshift-logging

[objectiser]

"Spark dependencies are not currently supported with this feature link:...."