Unmarshall numbers in options to number not float64 #308
Conversation
Signed-off-by: Pavol Loffay <[email protected]>
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 88.64% 88.68% +0.04%
==========================================
Files 70 70
Lines 3143 3156 +13
==========================================
+ Hits 2786 2799 +13
Misses 244 244
Partials 113 113
Continue to review full report at Codecov.
|
| @@ -38,7 +39,11 @@ func (o *Options) Filter(prefix string) Options { | |||
| // UnmarshalJSON implements an alternative parser for this field | |||
| func (o *Options) UnmarshalJSON(b []byte) error { | |||
| var entries map[string]interface{} | |||
| json.Unmarshal(b, &entries) | |||
| d := json.NewDecoder(bytes.NewReader(b)) | |||
| d.UseNumber() | |||
There was a problem hiding this comment.
A bit of context: JSON spec defines numbers as float64 so all number are by default unmarshalled to float64. Our Options.Args() method uses fmt.Sprintf(%v, val) to convert the value to string - the %v formats the float into exponent notation e.g. 5e+06
There was a problem hiding this comment.
Thanks for the details - would it be possible to provide a test?
There was a problem hiding this comment.
Including one that fails the decode, just to improve the code coverage.
There was a problem hiding this comment.
Apart from it is it ok?
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Resolves #302
Signed-off-by: Pavol Loffay [email protected]