Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaeger version to 1.11 #300

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

Signed-off-by: Pavol Loffay <[email protected]>
@jpkrohling
Copy link
Contributor

This change is Reviewable

@pavolloffay pavolloffay requested a review from objectiser March 12, 2019 12:58
Signed-off-by: Pavol Loffay <[email protected]>
@codecov
Copy link

codecov bot commented Mar 12, 2019

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files          70       70           
  Lines        3119     3119           
=======================================
  Hits         2762     2762           
  Misses        244      244           
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44208d9...d80c5f1. Read the comment docs.

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking at the olm, and found that the release.sh updates the versions automatically on release, including the deploy/operator.yaml - so wondering whether my previous change should be reverted - keep some of the docs to explain the situation, but not use the master version.
We still need to work out a procedure around where the instructions are no longer aligned with the current stable version though.

@objectiser
Copy link
Contributor

@pavolloffay If you agree, let me know and I will create a PR to back out the master change.

@pavolloffay
Copy link
Member Author

@objectiser as you want. the release will be soon so it will be overridden anyways no?

@pavolloffay pavolloffay merged commit 88d13c4 into jaegertracing:master Mar 12, 2019
@objectiser
Copy link
Contributor

@pavolloffay ok will wait for release and then update the readme appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants