Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable agent readiness probe #297

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

Signed-off-by: Pavol Loffay <[email protected]>
@jpkrohling
Copy link
Contributor

This change is Reviewable

@pavolloffay pavolloffay requested a review from objectiser March 11, 2019 16:58
@objectiser
Copy link
Contributor

@pavolloffay travis failed - I had same issue and had to restart the build - looks like a spurious problem finding golint.

@pavolloffay
Copy link
Member Author

I will have a look at it

@pavolloffay
Copy link
Member Author

locally the installation worked well. I will restart it again

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #297 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   88.52%   88.55%   +0.03%     
==========================================
  Files          70       70              
  Lines        3110     3119       +9     
==========================================
+ Hits         2753     2762       +9     
  Misses        244      244              
  Partials      113      113
Impacted Files Coverage Δ
pkg/deployment/agent.go 100% <100%> (ø) ⬆️
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e5250...09ac265. Read the comment docs.

@pavolloffay pavolloffay merged commit 44208d9 into jaegertracing:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants