Added note about the apiVersion used up to 1.10.0 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
======================================
Coverage 89.8% 89.8%
======================================
Files 64 64
Lines 3011 3011
======================================
Hits 2704 2704
Misses 207 207
Partials 100 100Continue to review full report at Codecov.
|
|
@objectiser, is this OK to be merged? |
objectiser
reviewed
Mar 19, 2019
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/service_account.yaml | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/role.yaml | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/role_binding.yaml | ||
| kubectl create -f https://raw.githubusercontent.com/jaegertracing/jaeger-operator/master/deploy/operator.yaml | ||
| ---- | ||
| <1> This creates the namespace used by default in the deployment files. | ||
| <2> This installs the "Custom Resource Definition" for the `apiVersion: jaegertracing.io/v1` | ||
|
|
||
| IMPORTANT: when using a Jaeger Operator up to v1.10.0, install the CRD file `io_v1alpha1_jaeger_crd.yaml` in addition to `jaegertracing_v1_jaeger_crd.yaml`. This is because up to that version, the `apiVersion` in use was `io.jaegertracing/v1alpha1`. |
There was a problem hiding this comment.
Should this notice be included below aswell?
There was a problem hiding this comment.
Added. Our ultimate goal is to remove the OpenShift-specific instructions, but until that, we should indeed duplicate the instructions.
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
Note-about-CRD-up-to-1.10.0
branch
from
dc0ccf8 to
cf6d9f1
Compare
objectiser
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling [email protected]