Updated to Operator SDK 0.5.0

[jpkrohling]

Closes #272

Signed-off-by: Juraci Paixão Kröhling [email protected]

[jpkrohling]

This change is 

[codecov]

Codecov Report

Merging #273 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   89.02%   88.96%   -0.06%     
==========================================
  Files          70       71       +1     
  Lines        3089     3091       +2     
==========================================
  Hits         2750     2750              
- Misses        226      228       +2     
  Partials      113      113

Impacted Files	Coverage Δ
pkg/apis/jaegertracing/v1/freeform.go	85.71% <ø> (ø)	⬆️
pkg/apis/jaegertracing/v1/jaeger_types.go	100% <ø> (ø)	⬆️
...ntauthentication/v1alpha1/zz_generated.defaults.go	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898bb43...f809a3c. Read the comment docs.

[objectiser]

LGTM - although next time doing a big dependency upgrade, would be better to commit the vendor changes in a separate commit to the code changes 😄

[objectiser]

Does this port have any particular significance? Would it be better to have something in the same ballpark as other Jaeger ports?

[jpkrohling]

The port 60000 didn't seem to be used and is probably a left-over from a copy/paste or generated code.

The port 8383 is the one used in newly created operators.

[pavolloffay]

@jpkrohling could you please make sure that self-provisioning of ES cluster works? You mentioned that this one generates more one additional file and ES files contains only one generated file.

[jpkrohling]

could you please make sure that self-provisioning of ES cluster works?

This really needs an e2e test... It's on your queue, right?

The ES operator is currently not working for me, but seems to be something unrelated to this PR:

time="2019-03-07T13:40:34Z" level=error msg="error syncing key (myproject/elasticsearch): Failed to reconcile Roles and RoleBindings for Elasticsearch cluster: failed to create ClusterRole elasticsearch-metrics: clusterroles.rbac.authorization.k8s.io is forbidden: User \"system:serviceaccount:openshift-logging:elasticsearch-operator\" cannot create clusterroles.rbac.authorization.k8s.io at the cluster scope: no RBAC policy matched"

[jpkrohling]

would be better to commit the vendor changes in a separate commit to the code changes

Great idea, will do that!

[jpkrohling]

I'm merging, as @pavolloffay tested the self-provision and it works.