Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus scrape annotations to Jaeger collector, query and all-… #27

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

objectiser
Copy link
Contributor

…in-one

This PR allows an existing prometheus deployment to scrape the metrics from the Jaeger backend.

Currently the agent is not annotated, as only appears to be support for injecting sidecar. Will create a separate issue to explore how to annotate agent sidecar, and daemonset when supported.

@objectiser
Copy link
Contributor Author

objectiser commented Sep 13, 2018

The prometheus discovery process makes use of the rewrite rules to determine whether a pod (or service endpoint) should be scraped, and optionally what path and port to use. Identifying the pods/service endpoints is based on its integration with kubernetes.

@jpkrohling jpkrohling merged commit ab78bb8 into jaegertracing:master Sep 13, 2018
@objectiser objectiser deleted the prom branch September 13, 2018 15:46
dt-cloner bot pushed a commit to IshwarKanse/jaeger-operator that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants