Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Operator provider to CNCF #263

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Change Operator provider to CNCF #263

merged 2 commits into from
Mar 22, 2019

Conversation

objectiser
Copy link
Contributor

Change provider from Jaeger to CNCF to enable it to be listed with other CNCF project operators.

@awgreene Would you be able to review and confirm this an appropriate change to update the provider used on operatorhub.io? If so, how does the update get applied to the hub?

Signed-off-by: Gary Brown [email protected]

@jpkrohling
Copy link
Contributor

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          64       64           
  Lines        3014     3014           
=======================================
  Hits         2707     2707           
  Misses        207      207           
  Partials      100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e147512...f721c1a. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jpkrohling
Copy link
Contributor

Just waiting for @awgreene's OK to merge this.

@objectiser
Copy link
Contributor Author

@awgreene Is it ok to change the provider? and if so, is this PR ok or is anything else required?

@awgreene
Copy link
Contributor

If CNFF is the provider please feel free to update the field.

Best practice is to create a new csv vand add the replaces field. Just make sure to create a PR against the community-oeprators repo

@objectiser
Copy link
Contributor Author

@jpkrohling I've updated the release.sh based on @awgreene 's comment about specifying the replaces field - so that this should automatically now be set to the version it is replacing. Would be good if we can get this in before doing the release.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need a clarification about the replaces

.travis/release.sh Show resolved Hide resolved
@jpkrohling jpkrohling merged commit 65c5f04 into jaegertracing:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants