apis/v1: add jaeger agent deprecation warning #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedikt Bongartz <[email protected]>
iblancasa
approved these changes
Feb 14, 2024
frzifus
commented
Feb 14, 2024
| @@ -48,6 +48,7 @@ func (j *Jaeger) objsWithOptions() []*Options { | |||
| // Default implements webhook.Defaulter so a webhook will be registered for the type | |||
| func (j *Jaeger) Default() { | |||
| jaegerlog.Info("default", "name", j.Name) | |||
| jaegerlog.Info("WARNING jaeger-agent is deprecated and will removed in v1.55.0. See https://github.com/jaegertracing/jaeger/issues/4739", "component", "agent") | |||
There was a problem hiding this comment.
Just for the record, I added it here and not in the webhook for the sidecar injection since its the agent can also be deployed as a daemonset.
There was a problem hiding this comment.
Please update the linked issue in the root repository once the changes are done in the operator
pavolloffay
approved these changes
Feb 14, 2024
| @@ -48,6 +48,7 @@ func (j *Jaeger) objsWithOptions() []*Options { | |||
| // Default implements webhook.Defaulter so a webhook will be registered for the type | |||
| func (j *Jaeger) Default() { | |||
| jaegerlog.Info("default", "name", j.Name) | |||
| jaegerlog.Info("WARNING jaeger-agent is deprecated and will removed in v1.55.0. See https://github.com/jaegertracing/jaeger/issues/4739", "component", "agent") | |||
There was a problem hiding this comment.
Please update the linked issue in the root repository once the changes are done in the operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test