enable errorlint and testifylint linters

[mmorel-35]

Which problem is this PR solving?

Description of the changes

• applies errorlint and testifylint linters

How was this change tested?

• The ci passes

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[openshift-ci]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (01f7dbb) 87.70% compared to head (b5e8908) 87.70%.
Report is 3 commits behind head on main.

❗ Current head b5e8908 differs from pull request most recent head de86e56. Consider uploading reports for the commit de86e56 to get more accurate results

Files	Patch %	Lines
pkg/storage/elasticsearch_secrets.go	33.33%	2 Missing ⚠️
pkg/controller/jaeger/elasticsearch.go	0.00%	1 Missing ⚠️
pkg/controller/jaeger/jaeger_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2385      +/-   ##
==========================================
- Coverage   87.70%   87.70%   -0.01%     
==========================================
  Files         102      102              
  Lines        7266     7262       -4     
==========================================
- Hits         6373     6369       -4     
  Misses        697      697              
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iblancasa]

Hi @mmorel-35, thanks for your PR!
To make it easier to track the changes and review the PR, could you split it? For instance, one could be enabling the linters, and the other one enabling errorlint and testifylint linters.

Thanks!

[mmorel-35]

Isn't the "ok-to-test" label missing ?

[iblancasa]

Isn't the "ok-to-test" label missing ?

Yes, but I wanted the @rubenvp8510 review before adding it.