Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiVersion and kind are missing in jaeger-operator generate output #2281

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

hiteshwani29
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Added missing ApiVersion and Kind for HPA and Cronjobs

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

Hi @hiteshwani29. Thanks for your PR.

I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.83% 🎉

Comparison is base (df40425) 87.58% compared to head (eade270) 88.42%.

❗ Current head eade270 differs from pull request most recent head 18765be. Consider uploading reports for the commit 18765be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
+ Coverage   87.58%   88.42%   +0.83%     
==========================================
  Files         100      100              
  Lines        7009     7049      +40     
==========================================
+ Hits         6139     6233      +94     
+ Misses        666      620      -46     
+ Partials      204      196       -8     
Files Changed Coverage Δ
pkg/cronjob/es_index_cleaner.go 97.97% <100.00%> (+13.36%) ⬆️
pkg/cronjob/es_rollover.go 96.72% <100.00%> (+17.67%) ⬆️
pkg/cronjob/spark_dependencies.go 91.42% <100.00%> (+10.36%) ⬆️
pkg/deployment/autoscale.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiteshwani29 hiteshwani29 marked this pull request as ready for review August 3, 2023 06:05
@iblancasa iblancasa enabled auto-merge (squash) August 7, 2023 10:11
@iblancasa
Copy link
Collaborator

/retest

@hiteshwani29
Copy link
Contributor Author

/retest-required

@iblancasa
Copy link
Collaborator

/retest

@iblancasa iblancasa merged commit c122932 into jaegertracing:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: apiVersion and kind are missing in jaeger-operator generate output
2 participants