Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing exposed port 16685 in query deployments #2239

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Add the port to the "all in one" and "query" deployments

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (4c7188e) 87.51% compared to head (b8b2cb1) 87.52%.

❗ Current head b8b2cb1 differs from pull request most recent head 4045326. Consider uploading reports for the commit 4045326 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
+ Coverage   87.51%   87.52%   +0.01%     
==========================================
  Files         100      100              
  Lines        6914     6920       +6     
==========================================
+ Hits         6051     6057       +6     
  Misses        658      658              
  Partials      205      205              
Impacted Files Coverage Δ
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)
pkg/deployment/query.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iblancasa iblancasa requested a review from rubenvp8510 June 15, 2023 17:33
@iblancasa iblancasa self-assigned this Jun 15, 2023
@iblancasa iblancasa added bug Something isn't working go Pull requests that update Go code labels Jun 15, 2023
@rubenvp8510
Copy link
Collaborator

LGTM! Thanks!

@rubenvp8510 rubenvp8510 enabled auto-merge (squash) June 16, 2023 04:57
@rubenvp8510 rubenvp8510 merged commit b5991c0 into jaegertracing:main Jun 16, 2023
@iblancasa iblancasa deleted the bug/2238 branch June 16, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting GRPC server 16685 connection refused
2 participants