Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kubernetes 1.27 #2235

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Upgraded controller-gen
  • Upgraded Kubernetes libraries to v1.27.2
  • Upgrade controller-runtime to 0.15.0
  • Fix breaking changes

Warning
The unit tests are failing with some problems related to the fakeclient. It seems to be kubernetes-sigs/controller-runtime#2362

Warning
The operator-lib dependency uses one commit instead of the latest released version (github.com/operator-framework/operator-lib v0.11.1-0.20230607132417-ecb9be488378) because operator-framework/operator-lib#115

Pending:

  • Add the new Kubernetes version to the E2E tests

@frzifus
Copy link
Member

frzifus commented Jun 14, 2023

This branch is not up-to-date and the CI is failing:

 Checking...
Go fmt, license check, or import ordering failures, run 'make format'
apis/v1/jaeger_webhook_test.go

@iblancasa
Copy link
Collaborator Author

This branch is not up-to-date and the CI is failing:

 Checking...
Go fmt, license check, or import ordering failures, run 'make format'
apis/v1/jaeger_webhook_test.go

The CI is gonna fail anyway because of what I pointed out in the first message.

Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa requested a review from rubenvp8510 June 28, 2023 20:30
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@97c5a50). Click here to learn what that means.
Patch coverage: 46.01% of modified lines in pull request are covered.

❗ Current head 8ccac03 differs from pull request most recent head 0ef9295. Consider uploading reports for the commit 0ef9295 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2235   +/-   ##
=======================================
  Coverage        ?   87.63%           
=======================================
  Files           ?      100           
  Lines           ?     6956           
  Branches        ?        0           
=======================================
  Hits            ?     6096           
  Misses          ?      656           
  Partials        ?      204           
Impacted Files Coverage Δ
controllers/jaegertracing/jaeger_controller.go 35.71% <0.00%> (ø)
pkg/controller/jaeger/kafka.go 61.53% <30.76%> (ø)
pkg/controller/jaeger/kafkauser.go 60.60% <30.76%> (ø)
pkg/controller/jaeger/elasticsearch.go 62.93% <48.33%> (ø)
pkg/controller/jaeger/dependencies.go 62.29% <52.77%> (ø)
pkg/controller/jaeger/deployment.go 71.42% <57.89%> (ø)
apis/v1/jaeger_webhook.go 87.50% <100.00%> (ø)
controllers/appsv1/deployment_webhook.go 85.04% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iblancasa iblancasa marked this pull request as ready for review June 28, 2023 20:46
@frzifus
Copy link
Member

frzifus commented Jun 29, 2023

@rubenvp8510 can we force this?

@rubenvp8510
Copy link
Collaborator

@rubenvp8510 can we force this?

Sure thing.

@rubenvp8510 rubenvp8510 merged commit 8289578 into jaegertracing:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add support for Kubernetes 1.27
3 participants