Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource limitation for the operator pod #2221

Merged
merged 7 commits into from
Jun 14, 2023

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Remove the resource limitation in the operator

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5244636) 87.51% compared to head (41ede3b) 87.51%.

❗ Current head 41ede3b differs from pull request most recent head 2df4329. Consider uploading reports for the commit 2df4329 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2221   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         100      100           
  Lines        6912     6912           
=======================================
  Hits         6049     6049           
  Misses        658      658           
  Partials      205      205           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iblancasa iblancasa force-pushed the bug/2220 branch 3 times, most recently from 705acc9 to 74242ed Compare May 26, 2023 13:56
frzifus
frzifus previously approved these changes May 30, 2023
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iam not sure if that the way how we should solve that. But fine. ^^

@frzifus frzifus enabled auto-merge (squash) May 30, 2023 11:35
auto-merge was automatically disabled May 31, 2023 10:47

Head branch was pushed to by a user without write access

@iblancasa
Copy link
Collaborator Author

Iam not sure if that the way how we should solve that. But fine. ^^

@frzifus thanks for accepting the PR :D

From the OpenShift guidelines:

Therefore, cluster components SHOULD NOT be configured with resource limits.

However, cluster components MUST declare resource requests for both CPU and memory.

Signed-off-by: Israel Blancas <[email protected]>
@frzifus frzifus enabled auto-merge (squash) May 31, 2023 16:53
@frzifus
Copy link
Member

frzifus commented Jun 12, 2023

From the OpenShift guidelines:

Thx @iblancasa, can you update your branch? I can not, seems you restrict this :)

@frzifus frzifus merged commit 6538461 into jaegertracing:main Jun 14, 2023
@iblancasa iblancasa deleted the bug/2220 branch June 14, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants