Expose admin ports for agent, collector, and query Deployments via the equivalent Service #2204
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
- Coverage 87.63% 87.54% -0.09%
==========================================
Files 100 100
Lines 6956 6930 -26
==========================================
- Hits 6096 6067 -29
- Misses 656 658 +2
- Partials 204 205 +1
☔ View full report in Codecov by Sentry. |
|
oh it seems some basic tests are still failing |
|
@thomaspaulin could you take a look to the failing tests? |
|
@iblancasa Sure thing, I'll take a look at the tests. |
|
seems there is still something wrong here: https://github.com/jaegertracing/jaeger-operator/actions/runs/5410048296/jobs/9830973296#step:6:1541 |
pkg/service/query_test.go
Outdated
| assert.Equal(t, int32(32767), svc.Spec.Ports[0].NodePort) // make sure we get the same NodePort as set above | ||
| assert.Equal(t, intstr.FromInt(16686), svc.Spec.Ports[0].TargetPort) | ||
| assert.Equal(t, intstr.FromInt(16687), svc.Spec.Ports[1].TargetPort) | ||
| assert.Equal(t, intstr.FromInt(16687), svc.Spec.Ports[2].TargetPort) |
Pull request was closed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: frzifus, thomaspaulin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
mh... @thomaspaulin I pushed to your branch and now then it was closed? And i also can not see the changes on your main branch https://github.com/thomaspaulin/jaeger-operator/tree/main - that's weird |
|
@frzifus how odd, thanks for creating a new PR with the fixes! |
Which problem is this PR solving?
Resolves #2203
Short description of the changes
/metricsendpoint on that port and therefore monitoring of Jaeger itself.