-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add NodeSelector
to jaeger collector, query, and ingestor
#2200
Feat: add NodeSelector
to jaeger collector, query, and ingestor
#2200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of it @AhmedGrati!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
+ Coverage 87.47% 87.50% +0.03%
==========================================
Files 100 100
Lines 6890 6908 +18
==========================================
+ Hits 6027 6045 +18
Misses 658 658
Partials 205 205
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@frzifus do you have an idea about the issue? it seems that it's irrelevant to the PR. |
Not sure, i will try to look into it in the next days. |
Head branch was pushed to by a user without write access
0077fb9
to
a624090
Compare
Signed-off-by: AhmedGrati <[email protected]>
a624090
to
02f81fe
Compare
@frzifus I think it's ready now. |
I triggered a re-run - fixing the flaky test would be awesome :) |
…ertracing#2200) Signed-off-by: AhmedGrati <[email protected]> Signed-off-by: Israel Blancas <[email protected]>
Which problem is this PR solving?
Short description of the changes