Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add NodeSelector to jaeger collector, query, and ingestor #2200

Merged

Conversation

AhmedGrati
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update collector, query, and ingester CRD.
  • Add unit tests of the previous changes.

@frzifus frzifus enabled auto-merge (squash) March 25, 2023 22:02
frzifus
frzifus previously approved these changes Mar 25, 2023
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it @AhmedGrati!

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (5e1bc59) 87.47% compared to head (8b05e93) 87.50%.

❗ Current head 8b05e93 differs from pull request most recent head 21c6ae7. Consider uploading reports for the commit 21c6ae7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
+ Coverage   87.47%   87.50%   +0.03%     
==========================================
  Files         100      100              
  Lines        6890     6908      +18     
==========================================
+ Hits         6027     6045      +18     
  Misses        658      658              
  Partials      205      205              
Impacted Files Coverage Δ
apis/v1/jaeger_types.go 87.50% <ø> (ø)
pkg/deployment/collector.go 100.00% <100.00%> (ø)
pkg/deployment/ingester.go 94.77% <100.00%> (+0.21%) ⬆️
pkg/deployment/query.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AhmedGrati
Copy link
Contributor Author

@frzifus do you have an idea about the issue? it seems that it's irrelevant to the PR.

@frzifus
Copy link
Member

frzifus commented Mar 26, 2023

Not sure, i will try to look into it in the next days.

auto-merge was automatically disabled March 31, 2023 23:59

Head branch was pushed to by a user without write access

@AhmedGrati AhmedGrati force-pushed the f-add-nodeselector-to-jaeger-operator branch from 0077fb9 to a624090 Compare March 31, 2023 23:59
@AhmedGrati AhmedGrati force-pushed the f-add-nodeselector-to-jaeger-operator branch from a624090 to 02f81fe Compare April 1, 2023 17:34
@AhmedGrati
Copy link
Contributor Author

AhmedGrati commented Apr 1, 2023

@frzifus I think it's ready now.
As for the Run miscellaneous E2E tests, I saw that it's been failing for a while, and we can fix it in another PR if you want.

@frzifus
Copy link
Member

frzifus commented Apr 3, 2023

As for the Run miscellaneous E2E tests, I saw that it's been failing for a while, and we can fix it in another PR if you want.

I triggered a re-run - fixing the flaky test would be awesome :)

@frzifus frzifus enabled auto-merge (squash) April 3, 2023 15:13
@frzifus frzifus merged commit a3dfc7e into jaegertracing:main Apr 4, 2023
iblancasa pushed a commit to iblancasa/jaeger-operator that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jaegeroperator to support nodeSelector
3 participants