Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability of detecting the platform #217

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

jpkrohling
Copy link
Contributor

Fixes #133 by implementing a way of detecting when we are running in OpenShift. If a "route" resource cannot be found, we assume we are running in Kubernetes.

When running in OpenShift, this is th expected output:

$ make run
customresourcedefinition.apiextensions.k8s.io/jaegers.io.jaegertracing created
INFO[0000] Go                                            arch=amd64 os=linux version=go1.11.1
INFO[0000] operator-sdk                                  version=v0.4.1
DEBU[0000] Attempting to auto-detect the platform       
INFO[0000] Auto-detected the platform                    platform=openshift

And this is the expected output for Kubernetes:

$ make run
customresourcedefinition.apiextensions.k8s.io/jaegers.io.jaegertracing created
INFO[0000] Go                                            arch=amd64 os=linux version=go1.11.1
INFO[0000] operator-sdk                                  version=v0.4.1
DEBU[0000] Attempting to auto-detect the platform       
INFO[0000] Auto-detected the platform                    platform=kubernetes

This PR also removes the content about --platform=openshift, which is still available to override the auto-detect routine.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          35       35           
  Lines        1848     1848           
=======================================
  Hits         1759     1759           
  Misses         75       75           
  Partials       14       14
Impacted Files Coverage Δ
pkg/apis/io/v1alpha1/jaeger_types.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7f9241...29ff938. Read the comment docs.

@jpkrohling jpkrohling changed the title Added capability of detecting the platform WIP - Added capability of detecting the platform Feb 21, 2019
README.adoc Show resolved Hide resolved
pkg/cmd/start/main.go Outdated Show resolved Hide resolved
@jpkrohling jpkrohling changed the title WIP - Added capability of detecting the platform Added capability of detecting the platform Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants