Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Liveness Probe for Ingester and Query #2122

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix Liveness Probe for Ingester and Query #2122

merged 2 commits into from
Nov 22, 2022

Conversation

ricoberger
Copy link
Contributor

Which problem is this PR solving?

The liveness probes added in #1605 are not working for the ingester and query, because of a copy / paste mistake (sorry for that 😞).

Short description of the changes

This PR fixes the liveness probe configuration for the ingester and query.

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see 🤦 good catch!

@frzifus frzifus enabled auto-merge (squash) November 22, 2022 10:11
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 87.32% // Head: 87.32% // No change to project coverage 👍

Coverage data is based on head (7cdce9d) compared to base (8820ea5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2122   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         100      100           
  Lines        6865     6865           
=======================================
  Hits         5995     5995           
  Misses        667      667           
  Partials      203      203           
Impacted Files Coverage Δ
pkg/deployment/ingester.go 94.55% <100.00%> (ø)
pkg/deployment/query.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frzifus frzifus merged commit f3eb628 into jaegertracing:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants