-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Route to SDK Scheme #194
Added Route to SDK Scheme #194
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
======================================
Coverage 96.7% 96.7%
======================================
Files 32 32
Lines 1639 1639
======================================
Hits 1585 1585
Misses 41 41
Partials 13 13 Continue to review full report at Codecov.
|
The e2e tests for this PR are passing:
|
Did you run the e2e on OCP. IIRC they were passing on k8s even without this fix |
Unfortunately, the E2E tests won't work on OpenShift because some of them depend on the Ingress object. All other tests are passing, though. |
then they are not almost not relevant here ;) |
Fixes #136 by registering the Route scheme with the SDK Scheme Manager.
Signed-off-by: Juraci Paixão Kröhling [email protected]