-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: take namespace modifications into account #1839
fix: take namespace modifications into account #1839
Conversation
2d0a24c
to
09cd76a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
+ Coverage 89.06% 89.45% +0.38%
==========================================
Files 100 100
Lines 6147 6116 -31
==========================================
- Hits 5475 5471 -4
+ Misses 495 470 -25
+ Partials 177 175 -2
Continue to review full report at Codecov.
|
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
Previously the namespace reconciler was called by reconcile requests generated by the JaegerOnSync method. In jaegertracing#1838 the JaegerOnSync method changes an annotation of the namespace to call the reconcile loop. Since the reconciler was not registered for namespace changes, those were not immediately taken into account. Signed-off-by: Benedikt Bongartz <[email protected]>
29a7400
to
e93c092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Good Job!
Which problem is this PR solving?
Short description of the changes