Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RHOL Elasticsearch cert-management feature optional #1824

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

pavolloffay
Copy link
Member

The reason is that the cert-management is not supported on OCP 4.6.
The feature was added in RHOL 5.2 shipped on OCP 4.7.

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1824 (04e56ac) into main (a530a02) will increase coverage by 0.49%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   87.70%   88.19%   +0.49%     
==========================================
  Files         100      101       +1     
  Lines        6018     6142     +124     
==========================================
+ Hits         5278     5417     +139     
+ Misses        563      543      -20     
- Partials      177      182       +5     
Impacted Files Coverage Δ
apis/v1/jaeger_types.go 87.50% <ø> (ø)
pkg/controller/jaeger/jaeger_controller.go 50.54% <68.00%> (+5.14%) ⬆️
pkg/storage/elasticsearch_secrets.go 91.95% <91.95%> (ø)
pkg/storage/elasticsearch.go 97.46% <100.00%> (+17.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a530a02...04e56ac. Read the comment docs.

@pavolloffay pavolloffay reopened this Mar 23, 2022
@pavolloffay pavolloffay force-pushed the es-operator-4.6 branch 2 times, most recently from f7ffd88 to a104f2d Compare March 23, 2022 18:02
The reason is that the cert-management is not supported on OCP 4.6.
The feature was added in RHOL 5.2 shipped on OCP 4.7.

Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Copy link
Collaborator

@rubenvp8510 rubenvp8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants