Custom ImagePullPolicy and ImagePullSecrets #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: edenkoveshi <[email protected]>
handled within util.Merge, and then applied to all created containers. Relevant tests updated accordingly. Signed-off-by: edenkoveshi <[email protected]>
|
Hey @edenkoveshi, thanks for your contribution! ImagePullSecrets are already handled in #1740. What you think about placing your ImagePullPolicy changes on top of this? |
|
Funny I've missed it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Following this #1768
I have implemented a way to use custom ImagePullPolicy and ImagePullSecrets on the Jaeger components, allowing to customize it a bit more.
It's a feature I needed and it is a very minor and harmless change so I hope you approve :)
Short description of the changes
This is quite simple really.
I've added both corev1-defined objects to the JaegerCommonSpec and then handled it within the util.Merge function
And then I have added the policy and secrets from JaegerCommonSpec to the relevant containers being set up.
If any of them is not set, Kubernetes default is taken.
Following any other JaegerCommonSpec properties, those defined under Jaeger.Spec.JaegerCommonSpec are overwritten by the internal ones (Jaeger.Spec.Agent.JaegerCommonSpec,Jaeger.Spec.AllInOne.JaegerCommonSpec, etc.)
CRD Changes:
Test cases have been added and relevant tests updated. Also tested manually on a minikube environment.