Add CR Metrics for Jaeger Kind. #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 87.72% 87.70% -0.02%
==========================================
Files 98 98
Lines 5963 5964 +1
==========================================
Hits 5231 5231
- Misses 556 557 +1
Partials 176 176
Continue to review full report at Codecov.
|
pavolloffay
approved these changes
Jan 19, 2022
| @@ -58,7 +58,6 @@ func NewStartCommand() *cobra.Command { | |||
| AddFlags(cmd) | |||
| cmd.Flags().String("metrics-host", "0.0.0.0", "The host to bind the metrics port") | |||
| cmd.Flags().Int32("metrics-port", 8383, "The metrics port") | |||
| cmd.Flags().Int32("cr-metrics-port", 8686, "The metrics port for Operator and/or Custom Resource based metrics") | |||
There was a problem hiding this comment.
wondering why is this being removed?
There was a problem hiding this comment.
For previous versions of the operator-sdk the CR metrics was reported in a different endpoint, but now the CR metrics are reported in the same endpoint, so we are using metrics-port now for both the general metrics and the CR metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas [email protected]
Which problem is this PR solving?