util.Truncate add the values to the truncated after the excess is 0 #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Matache <[email protected]>
mmatache
force-pushed
the
fix-util.Truncate-not-adding-all-values-to-the-format-string
branch
from
1b988a6 to
e846a5e
Compare
jpkrohling
approved these changes
Dec 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
+ Coverage 87.68% 87.72% +0.03%
==========================================
Files 98 98
Lines 5962 5963 +1
==========================================
+ Hits 5228 5231 +3
+ Misses 557 556 -1
+ Partials 177 176 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves: #1677
Short description of the changes