Use CRDs to detect features in the cluster #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
commented
Nov 3, 2021
|
|
||
| return apiList, nil | ||
| func (b *Background) availableAPIs(_ context.Context) ([]*metav1.APIResourceList, error) { | ||
| return b.dcl.ServerPreferredResources() |
There was a problem hiding this comment.
b.dcl.ServerGroups() returns only the API groups and for instance logging.openshift.io has multiple kinds: elasticsearch, kibana ... Hence we should enable ES provisioning only if the elasticsearch kind is in the cluster.
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 87.61% 87.60% -0.01%
==========================================
Files 95 95
Lines 5968 5964 -4
==========================================
- Hits 5229 5225 -4
Misses 562 562
Partials 177 177
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
|
Code Looks good, just one question Why for this particular GroupVersion |
rubenvp8510
approved these changes
Nov 3, 2021
|
bc the vanilla OCP cluster already has some Kids in |
iblancasa
pushed a commit
to iblancasa/jaeger-operator
that referenced
this pull request
Nov 3, 2021
* Use CRDs to detect features in the cluster Signed-off-by: Pavol Loffay <[email protected]> * Revert Signed-off-by: Pavol Loffay <[email protected]> * Revert Signed-off-by: Pavol Loffay <[email protected]> * Revert Signed-off-by: Pavol Loffay <[email protected]> Signed-off-by: Israel Blancas <[email protected]>
rubenvp8510
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Merge stash Signed-off-by: Israel Blancas <[email protected]> * Add spark ES E2E test to KUTTL Signed-off-by: Israel Blancas <[email protected]> * Add simple ES prod test to KUTTL Signed-off-by: Israel Blancas <[email protected]> * Add makefile changes Signed-off-by: Israel Blancas <[email protected]> * FFirst version of the ES index cleaner test Signed-off-by: Israel Blancas <[email protected]> * Index cleaner tests migrated to KUTTL Signed-off-by: Israel Blancas <[email protected]> * Small refactor Signed-off-by: Israel Blancas <[email protected]> * Make ServiceMonitor creation optional (#1323) Signed-off-by: Igor Wiedler <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Signed-off-by: Israel Blancas <[email protected]> * Use CRDs to detect features in the cluster (#1608) * Use CRDs to detect features in the cluster Signed-off-by: Pavol Loffay <[email protected]> * Revert Signed-off-by: Pavol Loffay <[email protected]> * Revert Signed-off-by: Pavol Loffay <[email protected]> * Revert Signed-off-by: Pavol Loffay <[email protected]> Signed-off-by: Israel Blancas <[email protected]> * Apply changes suggested in CR Signed-off-by: Israel Blancas <[email protected]> Co-authored-by: Igor <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.