Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC flags for OpenShift when 'reporter.grpc.host-port' is defined #1584

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

Git-Jiro
Copy link
Contributor

@Git-Jiro Git-Jiro commented Oct 16, 2021

Which problem is this PR solving?

Short description of the changes

  • Do not set default gRPC parameters if CR defines 'reporter.grpc.host-port'

Signed-off-by: Martin Schimandl <[email protected]>
@Git-Jiro Git-Jiro force-pushed the fix_grpc_flags_openshift branch from dda35cd to 82258f7 Compare October 16, 2021 15:15
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1584 (bfae969) into master (d9e6533) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          94       94           
  Lines        5956     5959    +3     
=======================================
+ Hits         5217     5220    +3     
  Misses        562      562           
  Partials      177      177           
Impacted Files Coverage Δ
pkg/config/tls/tls.go 91.30% <100.00%> (+0.82%) ⬆️
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e6533...bfae969. Read the comment docs.

Copy link
Collaborator

@rubenvp8510 rubenvp8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenvp8510 rubenvp8510 enabled auto-merge (squash) October 20, 2021 05:13
@rubenvp8510 rubenvp8510 merged commit fca67bf into jaegertracing:master Oct 20, 2021
@Git-Jiro Git-Jiro deleted the fix_grpc_flags_openshift branch October 20, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC flags shouldn't be added if host-port is specified by the CR
2 participants