Change default OpenShift query ingress SAR to pods in the jaeger namespace #1583
Conversation
…space Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
pkg/upgrade/versions.go
Outdated
| @@ -17,5 +17,6 @@ var ( | |||
| "1.18.0": upgrade1_18_0, | |||
| "1.20.0": upgrade1_20_0, | |||
| "1.22.0": upgrade1_22_0, | |||
| "1.27.0": upgrade1_27_0, | |||
There was a problem hiding this comment.
@rubenvp8510 when is this code being invoked?
Is it when upgrading from 1.27.0 to 1.28.0?
There was a problem hiding this comment.
no, IIRC this is invoked when we are going to migrate from versions earlier than 1.27.0 to 1.27.0
https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/upgrade/upgrade.go#L135
If you want to upgrade from version X to 1.28.0 you should create a new entry here.
There was a problem hiding this comment.
If you want to upgrade from version X to 1.28.0 you should create a new entry here
Where should I create a new entry? I have renamed the file to to match 1.28.0 and it looks like enough.
There was a problem hiding this comment.
Yes, sorry what I meant is you have to have the 1.28.0 entry, as you have it now :)
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
==========================================
+ Coverage 87.59% 87.61% +0.01%
==========================================
Files 94 95 +1
Lines 5956 5965 +9
==========================================
+ Hits 5217 5226 +9
Misses 562 562
Partials 177 177
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay [email protected]
Resolves https://issues.redhat.com/browse/TRACING-2213