Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add deployment strategy to crd #1499

Conversation

ethernoy
Copy link
Contributor

@ethernoy ethernoy commented Jul 3, 2021

Which problem is this PR solving?

Short description of the changes

  • Added deployment strategy customization for deployment of all-in-one, ingester, collector and query.

@ethernoy
Copy link
Contributor Author

ethernoy commented Jul 5, 2021

@jpkrohling Hi, I wonder what should I revise to pass the failing test?

@jpkrohling
Copy link
Contributor

Here's what I see from the build logs:

time="2021-07-05T09:57:34Z" level=info msg="Running deepcopy code-generation for Custom Resource group versions: [jaegertracing:[v1], kafka:[v1beta1], ]\n"
time="2021-07-05T09:58:01Z" level=info msg="Code-generation complete."
Formatting code...
Build failed: a model has been changed but the generated resources aren't up to date. Run 'make generate' and update your PR.

@ethernoy
Copy link
Contributor Author

ethernoy commented Jul 5, 2021

Here's what I see from the build logs:

time="2021-07-05T09:57:34Z" level=info msg="Running deepcopy code-generation for Custom Resource group versions: [jaegertracing:[v1], kafka:[v1beta1], ]\n"
time="2021-07-05T09:58:01Z" level=info msg="Code-generation complete."
Formatting code...
Build failed: a model has been changed but the generated resources aren't up to date. Run 'make generate' and update your PR.

I fixed some PATH issue in my development environment and rerun the code generation pipeline, seems it is fixed now.

@jpkrohling jpkrohling enabled auto-merge (squash) July 6, 2021 07:34
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1499 (d657024) into master (194cc4f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head d657024 differs from pull request most recent head 85f3815. Consider uploading reports for the commit 85f3815 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
+ Coverage   87.21%   87.26%   +0.05%     
==========================================
  Files          90       90              
  Lines        5005     5025      +20     
==========================================
+ Hits         4365     4385      +20     
  Misses        484      484              
  Partials      156      156              
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100.00% <ø> (ø)
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)
pkg/deployment/collector.go 100.00% <100.00%> (ø)
pkg/deployment/ingester.go 100.00% <100.00%> (ø)
pkg/deployment/query.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194cc4f...85f3815. Read the comment docs.

@jpkrohling jpkrohling merged commit da66abe into jaegertracing:master Jul 6, 2021
@ethernoy ethernoy deleted the feature/add-deployment-strategy-to-crd branch July 6, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Customization of Deployment Strategy
2 participants