-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add deployment strategy to crd #1499
Feature/add deployment strategy to crd #1499
Conversation
Signed-off-by: Ethern Su <[email protected]>
Signed-off-by: Ethern Su <[email protected]>
…ent-strategy-to-crd Signed-off-by: Ethern Su <[email protected]>
@jpkrohling Hi, I wonder what should I revise to pass the failing test? |
Here's what I see from the build logs:
|
Signed-off-by: Ethern Su <[email protected]>
I fixed some PATH issue in my development environment and rerun the code generation pipeline, seems it is fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #1499 +/- ##
==========================================
+ Coverage 87.21% 87.26% +0.05%
==========================================
Files 90 90
Lines 5005 5025 +20
==========================================
+ Hits 4365 4385 +20
Misses 484 484
Partials 156 156
Continue to review full report at Codecov.
|
Which problem is this PR solving?
Short description of the changes