-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jaeger operator to support strimzi operator 0.23.0 #1495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
+ Coverage 87.26% 87.28% +0.02%
==========================================
Files 90 90
Lines 5025 5033 +8
==========================================
+ Hits 4385 4393 +8
Misses 484 484
Partials 156 156
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked about expanding the compatibility matrix in the readme to mention which Strimzi versions are supported for each release. This change isn't part of this PR.
Not yet, but I'll add the matrix to this PR ;) |
9d75470
to
fd1de7f
Compare
I just added the matrix to the |
fd1de7f
to
ea6eeb8
Compare
README.md
Outdated
|-----------------|----------------------| | ||
| v1.23 | v1.19+ | | ||
| v1.22 | v1.18 to v1.20 | | ||
| Jaeger Operator | Kubernetes | Strimzi Operator | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the doc in a broader context, I believe this table should be moved one section up, as it includes versions from two sections.
Please merge this, latest version its failing to deploy since operator droped suport to v1beta2 https://strimzi.io/docs/operators/0.24.0/deploying.html#assembly-upgrade-resources-str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve as is but will send another PR with a suggestion for the readme.
Could you please fix the conflicts? |
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Co-authored-by: Juraci Paixão Kröhling <[email protected]> Signed-off-by: Ruben Vargas <[email protected]>
72cf2fe
to
685c5f4
Compare
Signed-off-by: Ruben Vargas [email protected]
Which problem is this PR solving?
Short description of the changes
v1beta2
API version