-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass ES_TIME_RANGE var to Spark dependencies job #1481
Conversation
@jpkrohling @kevinearls review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Head branch was pushed to by a user without write access
@jpkrohling please review again, I've fixed formatting |
Signed-off-by: Nikita Grishko <[email protected]>
Head branch was pushed to by a user without write access
@jpkrohling I'm sorry but can you please check PR again? This time I walked through contributing guide and ran everything except e2e tests. Hope everything is ok now. |
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
=======================================
Coverage 87.20% 87.21%
=======================================
Files 90 90
Lines 5003 5004 +1
=======================================
+ Hits 4363 4364 +1
Misses 484 484
Partials 156 156
Continue to review full report at Codecov.
|
I don't think the e2e failing is related to the changes made in this PR. There is an issue with the ingress test, which should be fixed by this PR: #1491 As soon as that PR is merged could you rebase? |
@rubenvp8510 yep, no problem |
PR rebased. |
@jpkrohling thank you for the help and maybe you know when new version of the operator will be available to use? |
Which problem is this PR solving?
ES_TIME_RANGE
to specify how far in the past the job should look to for spans. But that variable is missing in the operator. PR simply adds the possibility to pass the required variable.Short description of the changes
elasticsearchTimeRange
configuration option for Jaeger dependencies section