-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cassandraCreateSchema affinity #1475
add cassandraCreateSchema affinity #1475
Conversation
Signed-off-by: Chase Kiefer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1475 +/- ##
=======================================
Coverage 87.21% 87.21%
=======================================
Files 90 90
Lines 5004 5005 +1
=======================================
+ Hits 4364 4365 +1
Misses 484 484
Partials 156 156
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, wish to been merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This needs to be rebased. |
Signed-off-by: Chase Kiefer <[email protected]>
Signed-off-by: Chase Kiefer <[email protected]>
…thub.com/chasekiefer/jaeger-operator into 1471-cassandraCreateSchema-node-affinity Signed-off-by: Chase Kiefer <[email protected]>
faa763d
to
7133f82
Compare
End-to-end tests restarted. |
The tests keep failing: were you able to run them locally? Have you tried this change in a minikube cluster? |
I don't think the e2e failing is related to the changes made in this PR. There is an issue with the ingress test, which should be fixed by this PR: #1491 As soon as that PR is merged could you rebase? |
@rubenvp8510 Yes, I can. Thank you for pointing this out. |
That PR was merged and I just rebased this PR. |
Signed-off-by: Chase Kiefer [email protected]
Resolves #1471
Short description of the changes